Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map regions between AWS, Azure and GCP #384

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Map regions between AWS, Azure and GCP #384

merged 3 commits into from
Jul 29, 2022

Conversation

tal66
Copy link
Contributor

@tal66 tal66 commented Jul 26, 2022

Hi, does this seem like a good start to close #380?

Haven't updated AMIMAP yet, because you have a link for ubuntu AMI's but i see Amazon linux AMI's are used.
should i take it from here or the ubuntu link in the comments and change the others?

Copy link
Member

@goncalo-rodrigues goncalo-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! I have added a few comments but looks good overall!

resources/common/cloud_provider.go Outdated Show resolved Hide resolved
resources/common/cloud_provider.go Show resolved Hide resolved
resources/common/cloud_provider.go Outdated Show resolved Hide resolved
resources/common/cloud_provider.go Outdated Show resolved Hide resolved
resources/common/cloud_provider.go Outdated Show resolved Hide resolved
@goncalo-rodrigues
Copy link
Member

Perfect, thanks for making the changes!
There's a small problem with one of the tests because we were using a region that has more availability zones now, but I'll fix it.

@goncalo-rodrigues goncalo-rodrigues merged commit a9bb492 into multycloud:main Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map regions between AWS, Azure and GCP
2 participants