-
Notifications
You must be signed in to change notification settings - Fork 20
Adjust channel lock icons to adhere to the MetroMumble colour scheme #31
Conversation
@chili-b are the red and green tones you used for the looks the same tones that are used in other Mumble icons? Looking at the icons here on GitHub I still prefer the stronger tones I originally used for them but as has been mentioned in #28, it's inconsistent with the rest of the UI. Thus if you have chosen the colors to match the tones used throughout the rest of the UI, I'm totally fine with the changes you made to the lock icons 👍 The ear on the other hand is a different issue. I see how using the proposed icon instead of an actual ear stays closer to the icon set we already have. Thus this is a plus for consistency. I think ultimately though the choice here should only be made by comparing the icons within the UI instead of as individual icons. I will prepare a few screenshots that we can then compare side-by-side... |
Okay so here we go: I think I still prefer the old ear icon over the new one. But that could be due to me already being used to the "old" ones... Another advantage I see in with the old icons is that I could tell more quickly in which channel Another issue with the proposed icon is that users could think that it marks a new transmission state (similar to silent, speaking, shouting, whispering). It could of course be debated whether listening to a channel should indeed be seen as a new state in this area 🤔 |
I think we'll need a few more opinions on this topic. /cc @davidebeatrici @Kissaki @ZeroAbility @toby63 |
To answer your question: Yes, I copied the hex codes for the red and green tone from the regular not-talking indicator and self-mute icon respectively. I think that your concern about users confusing listen with a new transmission state is valid, but I'm leaning more towards saying it's okay because in the rest of the theme, transmission is always indicated by a change in colour as well as two curved lines on each side of the icon. Neither of these features are present in my proposed icon. |
Thx for pinging me 🙂. Regarding:
|
I have another suggestion for the listening indicator: Perhaps the link icon could be incorporated as users listening to channels is somewhat analogous to linking channels. I think that while the radio tower is related to the behaviour, the icon should try to avoid introducing new metaphors if possible. |
I think the link icon will not be understood. |
Using the chain would definitely be an option. What was also suggested in our meeting today was to use just the head of the current avatar icon (aka: a green circle) and then put some simple headphones on that and then use this as the icon for listeners. |
All great arguments here, thank you all for the very constructive discussion. Although this may not happen now or ever, I’d love to see a design documentation that shows and describes the icons with argumentation why they are used, for a feature and in relation to others. I agree with all of your arguments. Listening in results in a similar thing like linking channels. So we have a connection here. At the same time, it is on a user level. I do not think linking works here, because the user is an actor, not a structuring object/room. I may be worth thinking about replacing the link icon in the future for a more consistent icon theme between the two, but for now we can just look at the user. We also make linked channels cursive, so this may be worth a thought, but I think it's ultimately not helpful and more confusing. I am a little confused by the screenshot with the ear-icon replacement. Where am I as a user in this screenshot? I see two "listen in" actors in two channels. Am I in a different channel that is not visible? If the user listens in from another channel I would say they are more, closer connected to you. So the icon should be stronger rather than weaker. The suggested ear replacement is definitely a lot weaker than the default all green. So I think that icon would go against intuition and be misleading. My suggestion would be to try and use the ear, or even a simpler ear, and remove the "realistic" coloring. Simplify the ear icon to something that fits our icon and color scheme. Other users listening in to you is represented quite well with an ear icon [directed at you]. |
I think we should keep in mind that the icons are very small, so a too detailed approach is maybe not good. How about keeping the avatar but giving it a different colour? Update: Just noticed that black would be bad for the dark theme... |
The local user (aka "you") is the one highlighted in bold font. The screenshots are thus taken from different client's perspectives because I messed up on selecting the same one for the second screenshot xD
Listeners are already rendered in italics
I don't think I would follow this argument here. I would consider a user that is in the same channel as I am to be "closer" to me than someone that is only listening to what is spoken in my channel 🤔
Hm - let me see what I can come up with 🤔
That I definitely agree on 👍
Absolutely. That's what makes this so hard ^^
Even though that would of course be possible, I think it just wouldn't represent what this is supposed to stand for really well 🤔 |
Here are a few more suggestions for the ear icon: Bunny earsGreen earHeadphonesBunny ears: I don't think they quite fit into the rest of the theme The problem I faced when trying to reduce the ear shape's complexity was that as soon as I take away strokes from it, it's no longer recognizable as an ear (imo) 🤔 |
🤔 Honestly I don't think any of the suggestions are good (no offense). What about this:
|
@chili-b I think I like your suggestion 👍 @toby63 I don't think I like the idea of a robot icon. I would approve it for actual bots but listeners are no bots. And I'm not really sure what you mean by "tag". Where do you want to display such a tag? |
🤔 I guess you are right.
I found a better word for it now: a |
Just had a crazy idea, what about a vanishing avatar? |
Regarding the lock icons:
|
So far I like the green icon and also the idea of extending the existing user icon with additional state. Between the two, from the screenshots without gui context, I think I still prefer the ear though. What's the problem with the ear complexity? Is it an issue on small sizes? |
I agree someone in my channel is closer to me. They also hear me. But someone in another channel listening in is closer to me than someone in another channel not listening to me. I guess at the moment we do not have separate icons for own vs other channel though, ppl that can hear and those who can not. :) |
I think we should split this PR. There seems to be two concerns here. The lock icons color, which was discussed and seemingly quickly decided upon. And the ear icon which we are still discussing. @chili-b Can you split the two? They are separate concerns, and can be resolved at different speeds and independently. |
This one is actually already used in 1.4.0
I assume so. Though personally I did not have concerns ^^
I guess that could work. However as it stands to me it is now rather hard to recognize this as an ear without knowing that that's what it's supposed to be 🤔 |
Just sayin, the ear is really "horrible". It is not only about the perception and size. It is only an advice, but I would stick to the design decision xpoke made and leave such stuff out. If you can't find a better solution, use one of the ideas by @chili-b.
Just to clarify, I don't mean a grey avatar, I mean one with less colour, slightly lighter green tone for example. I also still prefer an icon with the avatar:
|
@Krzmbrzl |
I currently don't have a lot of time and since this is nothing urgent, I don't think I'll get to it any time soon. The ear suggestion currently need to be put in the software in order to get some proper screenshots. I did not get to doing that yet for the reasons mentioned above. So if someone wants to speed up the process, it'd be very helpful if these screenshots were created by someone else than me ☝️ |
Yes you are right, that would probably be helpful. |
So here is an overview of how the different icon concepts would look in Mumble: Headphones by @Krzmbrzl: Empty Avatar with Send by @chili-b : Vertical-Cut avatar (green/white) by me: Vertical-Cut avatar (green/grey) by me: Original Avatar for Comparison: My oppinion:
What about using a different symbole? |
Thanks for creating the screenshots 👍
My favorite would in fact be the headphone avatar. The line width of the headphone has to be increased but in terms of visibility and symbolic meaning this is the best option we have so far 🤔
Nah I don't think so. Making the icons larger would mean that a single user entry requires more space which will make you loose overview more quickly with growing users. And enlarging all icons just be did not found a good icon for one particular use-case yet seems a bit of an overkill anyways 🤷
How would that represent someone listening? If we are looking for a different symbol a microphone might be something to investigate (listening is kinda similar to someone recording what is spoken from a different room) 👀
So if
? Given that listeners don't show any other tags (afaik) this should be okay, I guess. Would have to look at that in code though. If we find a nice icon for it, I think a tag is superfluous though 🤔 |
I almost agree with the "most distinct" argument, but I think that we only recognize the headphones as such, because we know it (if you know what I mean).
I think this could only work for the avatar itself, but not for the send symbol next to it.
You are probably right about that.
The overview is an argument.
Well an arrow can mean the same thing as an old proposal with the link symbol.
I remember we already discussed this, but I might be wrong.
Yes. But I would like to have real label, not just text added to the username.
I think we will not find any icon that represents it perfectly, so this would be a clear and visible information. |
Fair enough. I think users initially thinking about the other client using headphones before realizing what this actually means is not too bad though since at least this would still be about the act of listening (to some degree anyways) which I think speaks for its symbolic character. In the end however I think that we either have to find more volunteers to evaluate the screenshots or make a decision based on our opinions even though it could be that we recognize certain images (better) because we know what it's supposed to be 🤷
But maybe better than some of the other approaches since a mic can stand for itself and does not need an auxiliary icon next to it (e.g. a head) to make sure what it is supposed to be. Thus it could use more of the available space for the actual icon.
So what would be a "label" for you? 'cause you say that icons are too small but it is not text that you had in mind. That now makes me wonder what kind of label you are thinking about 🤔 |
Thats probably a good idea, but they would need to be tested "blind", so they don't know the meaning and we ask them what this symbole means in their oppinion.
In general that would be true, but a microphone is more complicated than other items imo.
What I mean is not just adding text to the username like But to clarify, that is not a must-have, a simple text would be good as well (i think). |
Ah okay so sonething like a colored badge. Yes I think there is a FR for thst indeed. |
Sorry for the late response. I forgot that this PR was still open. I've undone the changes made to ear.svg so the only files modified are the lock icons. |
The red and green tones didn't match with the rest of the theme. This was corrected by this commit.
Thanks 👍 |
I cleaned up both lock icons. I also changed them such that they use the shades of red and green that are present elsewhere in the theme.I also changed the ear icon to an outlined avatar as I think this reads better. (also the human ear just feels a bit weird if I'm honest)
This isn't part of the PR, but I also suggest renaming 'ear.svg' to 'listen.svg' or something like that to improve clarity even if you reject this PR.I have undone the changes made to the ear icon as there was no consensus. As suggested by in #31 (comment), I have dedicated this PR to just the lock icons so that they can be added before the release of 1.4.0. I will open a new PR for further discussion on the listening icon.