WIP: Implement public server list #38
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was ready. And worked. But the fastly configuration changed and cross site loading didn't work anymore, unclear to me what or who changed it. I presented it when it worked but did receive little response. That’s why it’s still sitting here like this. |
|
Having a public server list on the website sounds like a really, really good idea! I'd prefer something that doesn't look like a markdown-table though if that's possible 🤔 |
|
Sure, we can improve the UI if this is something we want to implement and publish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17
Request for comments
Special care has to be taken to sanitize user input - namely server names and URLs.
Maybe simply not linking the URL as a hyperlink is the safe option. If a user wants to open it, modern browsers offer a text mark right click context action for opening the URL.
The
<details><summary>blocks do not work in IE. Maybe we should provide a JS alternative. Or post adequate error for IE users and not provide the content.