-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.5.517 RC crashes on launch after upgrading from v1.4.287 on MacOS Ventura 13.1 #6041
Comments
Can confirm I'm experiencing this too, the audio wizard opens up the first time you launch mumble, and regardless of whether you try to complete it or cancel it, it will crash the first time you press any of the buttons. |
@Newtoniano does the error message / backtrace also include a reference to an illegal instruction ( My guess here (which I thought I had written down earlier, but apparently not) is that there is some issue with cross-compiling that creates an illegal instruction in our binary that causes the crash. This is because we nowadays only have a M1 machine available to build our releases, so we have to cross-compile from ARM64 to x86_64 (ironically, we still don't provide native ARM64 binaries, but that is a different story). |
@Krzmbrzl Spot on, I get |
Okay, this proofs that cross-compiling has failed completely as it seems it will not run on M1 Macs nor on traditional x86 Macs... Great 🤦 |
I might have to revise my statement from above: I just compiled on an old x86_64 MacBook and I now get the error |
Nevermind, turns out this was a Segfault caused by the use of RNNoise. This would create a segfault in debug builds but in optimized builds the RNNoise code produced invalid instructions. |
Due to RNNoise being unmaintained and the library's code being in very poor shape, this commit excludes the RNNoise feature from Mumble by default and discourages its use. The library contains Opus and CELT symbols (probably due to copy&paste of code) that can end up being called from Opus instead of its own versions of these functions. This can lead to completely unforeseen behavior, including crashes. An example of this is as of writing this, enabling RNNoise on macOS leads to a crash of Mumble pretty much as soon as it starts up with an "invalid instruction" error. The reason being that part of RNNoise's implementation of one of Opus's symbols contains a code path that produces an invalid instruction in optimized builds (and a segfault in debug builds) and this code path is taken when Opus (wrongly) uses this function instead of its own. Fixes mumble-voip#6041
Due to RNNoise being unmaintained and the library's code being in very poor shape, this commit excludes the RNNoise feature from Mumble by default and discourages its use. The library contains Opus and CELT symbols (probably due to copy&paste of code) that can end up being called from Opus instead of its own versions of these functions. This can lead to completely unforeseen behavior, including crashes. An example of this is as of writing this, enabling RNNoise on macOS leads to a crash of Mumble pretty much as soon as it starts up with an "invalid instruction" error. The reason being that part of RNNoise's implementation of one of Opus's symbols contains a code path that produces an invalid instruction in optimized builds (and a segfault in debug builds) and this code path is taken when Opus (wrongly) uses this function instead of its own. Fixes mumble-voip#6041
Due to RNNoise being unmaintained and the library's code being in very poor shape, this commit excludes the RNNoise feature from Mumble by default and discourages its use. The library contains Opus and CELT symbols (probably due to copy&paste of code) that can end up being called from Opus instead of its own versions of these functions. This can lead to completely unforeseen behavior, including crashes. An example of this is as of writing this, enabling RNNoise on macOS leads to a crash of Mumble pretty much as soon as it starts up with an "invalid instruction" error. The reason being that part of RNNoise's implementation of one of Opus's symbols contains a code path that produces an invalid instruction in optimized builds (and a segfault in debug builds) and this code path is taken when Opus (wrongly) uses this function instead of its own. Fixes mumble-voip#6041
Due to RNNoise being unmaintained and the library's code being in very poor shape, this commit excludes the RNNoise feature from Mumble by default and discourages its use. The library contains Opus and CELT symbols (probably due to copy&paste of code) that can end up being called from Opus instead of its own versions of these functions. This can lead to completely unforeseen behavior, including crashes. An example of this is as of writing this, enabling RNNoise on macOS leads to a crash of Mumble pretty much as soon as it starts up with an "invalid instruction" error. The reason being that part of RNNoise's implementation of one of Opus's symbols contains a code path that produces an invalid instruction in optimized builds (and a segfault in debug builds) and this code path is taken when Opus (wrongly) uses this function instead of its own. Fixes #6041
Due to RNNoise being unmaintained and the library's code being in very poor shape, this commit excludes the RNNoise feature from Mumble by default and discourages its use. The library contains Opus and CELT symbols (probably due to copy&paste of code) that can end up being called from Opus instead of its own versions of these functions. This can lead to completely unforeseen behavior, including crashes. An example of this is as of writing this, enabling RNNoise on macOS leads to a crash of Mumble pretty much as soon as it starts up with an "invalid instruction" error. The reason being that part of RNNoise's implementation of one of Opus's symbols contains a code path that produces an invalid instruction in optimized builds (and a segfault in debug builds) and this code path is taken when Opus (wrongly) uses this function instead of its own. Fixes mumble-voip#6041
Description
Mumble v1.5.517 RC crashes on launch after upgrading from v1.4.287 on MacOS Ventura 13.1.
Steps to reproduce
Downloaded the .dmg installer. Drag and dropped to replace / upgrade in the Applications folder. Opened Mumble.
Note is that auto-connect to server was configured from the last version, so unsure if connecting has to happen before the crash).
Mumble version
v1.5.517
Mumble component
Client
OS
macOS
Reproducible?
Yes
Additional information
14" MBP w/ M1 Pro. Audio was set to default devices, RNNoise enabled.
Relevant log output
Screenshots
No response
The text was updated successfully, but these errors were encountered: