Add hotkey/toolbar icon to toggle RNNoise #5911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The concept is correct, however I would add a shortcut to cycle through all noise cancellation methods instead. |
Krzmbrzl
requested changes
Oct 3, 2022
| @@ -61,4 +61,3 @@ jobs: | |||
| working-directory: ${{ github.workspace }}/build | |||
| shell: bash | |||
| run: QT_QPA_PLATFORM=offscreen ctest --output-on-failure -C $BUILD_TYPE | |||
|
|
|||
| @@ -0,0 +1,12 @@ | |||
| sonar.projectKey=sethbrown246_mumble | |||
|
@sethbrown246 what is your plan with this PR? Do you want to finish it? |
Krzmbrzl
added
feature-request
|
Closing this due to being stale and in light of #6292 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
FEAT(ToggleRNNoise)
Hello, these are the changes I have made so far for trying to implement a global shortcut to toggle RNNoise. I believe the only thing left for me to do is to change Settings::noiseCancelMode but I was not sure how to do that. Let me know if what I have so far is good and if you have any tips on how to change Settings::noiseCancelMode to finish this issue.
Thanks in advance!
Implements #4189