-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REFAC(client): Get rid of launcher and DLL on Windows #6246
REFAC(client): Get rid of launcher and DLL on Windows #6246
Conversation
Lines 135 to 139 in c21a90a
I wonder what this is for, I would've expected the logic to be the opposite. |
set(overlay ON) | ||
set(plugins ON) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is appropriate here 🤔
These should be defaulted where they are declared and then not overwritten just because we're packaging. I realize that this is what we had in the old code, but I'm not sure this is something we should keep 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe they are forced because the installer code doesn't take into account whether the DLLs exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does for the overlay (at least there is a parameter) and maybe it would be best if it also did that for the plugins as well 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, let's do it in a separate pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be updated, too https://github.com/mumble-voip/mumble/blob/master/docs/dev/TheMumbleSourceCode.md#source-tree-layout
Other than that I have found not apparent issue with the changes. However, I am not qualified to substantially comment on Windows build processes :)
2171981
to
f70fef8
Compare
Thank you. As a bonus we also got rid of a typo ( As for the exported |
f70fef8
to
4587e75
Compare
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
No description provided.