Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding approve flag to all updata tasks #48

Merged
merged 1 commit into from
May 11, 2021

Conversation

mmbcn
Copy link
Contributor

@mmbcn mmbcn commented May 11, 2021

Tested it locally and it worked fine but as it is a module it need to be in the registry so would be nice if someone can review/approve it so it will be publicly available. Thx!

Copy link
Owner

@mumoshu mumoshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa! This was a terrible bug. It seems like I've been used too much on recreating eksctl cluster on every change 😅
Thank you so much for finding and fixing this @mmbcn!

@mumoshu mumoshu merged commit 684ed7f into mumoshu:master May 11, 2021
@mumoshu
Copy link
Owner

mumoshu commented May 11, 2021

v0.16.2 is being released for this.

@mmbcn
Copy link
Contributor Author

mmbcn commented May 11, 2021

@mumoshu No prob at all community power! :). Cheers to Japan and thx for pushing the new version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants