Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Allow users to be deleted #1592

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

faloi
Copy link
Contributor

@faloi faloi commented Mar 10, 2021

🎯 Goal

Closes mumuki/mumuki-domain#86

Allow users to be deleted.

🔜 Future work

I've only included a very basic text version of the confirmation email, it should be extended and complemented with an HTML version.

📸 Screenshots

Step 1 - delete request

image

eliminar-cuenta

image

Step 2 - delete confirmation, coming from email

Perhaps a bit confusing, because the modal is the same as previous step... we can change the text or the button, whatever.

image

Step 2 - invalid or expired token

I'm treating both cases the same way for security reasons - after all the user cannot do anything but starting the delete process again.

image

Step 3 - user disabled

Maybe we can also force a logout here or redirect to a "goodbye" page.

image

@faloi faloi marked this pull request as ready for review March 11, 2021 22:06
@faloi faloi requested a review from luchotc March 11, 2021 22:06
@faloi faloi force-pushed the feature-delete-user-account branch from d8fb3a3 to ebbe9b8 Compare March 11, 2021 23:13
@faloi faloi force-pushed the feature-delete-user-account branch from ebbe9b8 to 290b70d Compare March 11, 2021 23:20
Copy link
Contributor

@luchotc luchotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't played with it locally but this looks flawless 🔥 💯

private

def organic_domain_for(user)
Mumukit::Platform.laboratory.organic_domain(user.last_organization)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer to explicitly obtain organization from where the user clicked delete profile button


<div class="row">
<div class="col-md-12">
<%= t :delete_account_confirmation_email_explain_html, user_email: @user.email, support_email: Rails.configuration.reminder_sender_email %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not for you to address it @faloi, but we should define another configuration for Mumuki general purpose email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to be deleted
2 participants