Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint warnings support #1671

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

flbulgarelli
Copy link
Member

@flbulgarelli flbulgarelli commented Sep 6, 2021

🎯 Goal

To add support for eslint-generated smells.

📝 Details

This PR actually just updates dependencies on mumuki-domain, so that it incorporates new Mumukit::Inspection extensions for the JS language. All the real work actually occurs in that gem and the runner itself.

Currently, only support for missing semicolons was included.

📸 Screenshots

image

⚠️ Dependencies

🔙 Backwards compatibility

100%

🔜 Future work

We may add more eslint-based warnings in the runner without having to actually change anything here.

@flbulgarelli flbulgarelli changed the title Update dependencies Eslint warnings support Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant