Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature async massive notifications #1701

Closed
wants to merge 15 commits into from

Conversation

fedescarpa
Copy link
Member

🎯 Goal

Notifications and Jobs Consumers

📝 Details

Improve user profile notifications view to reuse the same view and logic of the user profile discussions view

📸 Screenshots

Add View more notifications in bell dropdown notifications menu
image

User Profile Discussions view
image

user Profile Notifications view
image

⚠️ Dependencies

🔙 Backwards compatibility

100%

@fedescarpa fedescarpa force-pushed the feature-async-massive-notifications branch 3 times, most recently from 21739af to f0e82ab Compare October 20, 2021 18:22
Copy link
Member

@julian-berbel julian-berbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

lib/mumuki/laboratory/jobs/jobs.rb Outdated Show resolved Hide resolved
@fedescarpa fedescarpa force-pushed the feature-async-massive-notifications branch from f0e82ab to 26f1d1a Compare November 11, 2021 18:34
@fedescarpa fedescarpa force-pushed the feature-async-massive-notifications branch from a6a53ec to e3b01a5 Compare November 15, 2021 18:52
Copy link
Member

@julian-berbel julian-berbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julian-berbel julian-berbel deleted the feature-async-massive-notifications branch November 25, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants