-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature async massive notifications #1701
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedescarpa
force-pushed
the
feature-async-massive-notifications
branch
3 times, most recently
from
October 20, 2021 18:22
21739af
to
f0e82ab
Compare
julian-berbel
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
fedescarpa
force-pushed
the
feature-async-massive-notifications
branch
from
November 11, 2021 18:34
f0e82ab
to
26f1d1a
Compare
fedescarpa
force-pushed
the
feature-async-massive-notifications
branch
from
November 15, 2021 18:52
a6a53ec
to
e3b01a5
Compare
fedescarpa
force-pushed
the
feature-async-massive-notifications
branch
from
November 15, 2021 20:35
e3b01a5
to
d4f713c
Compare
julian-berbel
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Notifications and Jobs Consumers
📝 Details
Improve user profile notifications view to reuse the same view and logic of the user profile discussions view
📸 Screenshots
Add View more notifications in bell dropdown notifications menu
User Profile Discussions view
user Profile Notifications view
🔙 Backwards compatibility
100%