Regression tests #22
Merged
Regression tests #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 21, 2023 23:09
* no explicit error code when NOT_KNOWN_ERROR * even for NOT_KNOWN_ERROR sqlstate is filled as this happens for custom sql states raised from plpgsql code
munakoiso
requested changes
Apr 25, 2023
|
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
fixed inaccurately not reported SQLSTATE in case of NOT_KNOWN_ERROR. in fact that is the case of custom sqlstate raised from plpgsql code and it makes perfect sense to report it. But main point of this PR is to enable PGXS regression tests.