Rework Video Capture backend to allow better isolation. #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding init and release methods to video capture backend interface we can completely separate implementation details from usage. We don't need to include (nor have) implementation header, and therefore can use true C++ for opencv implementation (no need for in-place ctor, explicit call to dtor, ...). Also, backend selection is done by name and multiple instanciation (with different parameters) can be done by selecting the right config section. Default video capture backend may be overrided at compile-time by defining DEFAULT_VIDEO_CAPTURE_BACKEND to appropriate value. Video input has been renamed to Video Capture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding init and release methods to video capture backend interface
we can completely separate implementation details from usage.
We don't need to include (nor have) backend implementation header,
and therefore can use true C++ for opencv implementation
(no need for in-place ctor, explicit call to dtor, ...).
Also, backend selection is done by name and multiple instanciation (with
different parameters) can be done by selecting the right config section.
Default video capture backend may be overrided at compile-time by
defining DEFAULT_VIDEO_CAPTURE_BACKEND to appropriate value.
Video input has been renamed to Video Capture.
If this PR gets merged, I will try to use the same pattern for other backends. This is a prelimiary step before audio/input plugin inclusion (as backend) inside the core.
For those who remember, the design is quite similar to what I did in a defunct PR mupen64plus/mupen64plus-ui-console#19.