Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix createApp return type #41

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Conversation

nicolapalavecino
Copy link
Collaborator

@nicolapalavecino nicolapalavecino commented Aug 31, 2023

This is a follow up of a previous PR #40

Description

This PR does 2 things:

  1. Narrow the return type of createApp from App<any, any> to App<TEntities, TSchema> (backward compatible)
  2. Stop returning the App in the new methods resetProvider and setProvider (not backward compatible)

Since 1 is backward compatible, and 2 is a very little change (which was release just a few days ago). The propsed bump version is a patch. From 4.8.0 to 4.8.1. Thoughts?

@nicolapalavecino nicolapalavecino force-pushed the fix/create-app-return-type branch from 780d814 to 7aae866 Compare August 31, 2023 03:21
Copy link
Collaborator

@micaelbergeron micaelbergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, LGTM

@nicolapalavecino nicolapalavecino merged commit ace9b4f into master Aug 31, 2023
@nicolapalavecino nicolapalavecino deleted the fix/create-app-return-type branch August 31, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants