Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IAM-1155] - provide thrown error details in return from computePermissions #44

Merged

Conversation

reidblomquist
Copy link
Contributor

@reidblomquist reidblomquist commented Jan 9, 2024

This is a backwards compatible change to support IAM platform work; specifically being able to provide denial reasons and/or remediation options when computing permissions.

Encapsulating this new information in a new $errors property on returned permissions keeps backwards-compatibility intact.

See this epic for more info: https://mural.atlassian.net/browse/IAM-1149

@reidblomquist reidblomquist marked this pull request as ready for review January 9, 2024 22:39
src/permissions/compute.ts Outdated Show resolved Hide resolved
@reidblomquist reidblomquist force-pushed the add/iam-1155-failure-reasons branch from 66ed7cf to 143f73f Compare January 10, 2024 23:17
Copy link
Collaborator

@nicolapalavecino nicolapalavecino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, sorry if this is still a WIP

src/permissions/compute.ts Outdated Show resolved Hide resolved
src/permissions/compute.ts Outdated Show resolved Hide resolved
src/permissions/compute.ts Outdated Show resolved Hide resolved
src/permissions/compute.ts Outdated Show resolved Hide resolved
@reidblomquist reidblomquist force-pushed the add/iam-1155-failure-reasons branch from 143f73f to c0e8a43 Compare January 11, 2024 16:10
@reidblomquist reidblomquist changed the title [IAM-1155] - add ability to provide tryPermission function to computePermissions [IAM-1155] - provide thrown error details in return from computePermissions so that clients ingesting might be better able to respond Jan 11, 2024
@reidblomquist reidblomquist changed the title [IAM-1155] - provide thrown error details in return from computePermissions so that clients ingesting might be better able to respond [IAM-1155] - provide thrown error details in return from computePermissions Jan 11, 2024
Copy link
Collaborator

@nicolapalavecino nicolapalavecino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

…ssions so that clients ingesting might be better able to respond
@reidblomquist reidblomquist force-pushed the add/iam-1155-failure-reasons branch from c0e8a43 to ca52b1b Compare January 16, 2024 15:39
@nicolapalavecino nicolapalavecino merged commit 16fb307 into muralco:master Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants