-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IAM-1155] - provide thrown error details in return from computePermissions #44
Merged
nicolapalavecino
merged 1 commit into
muralco:master
from
reidblomquist:add/iam-1155-failure-reasons
Jan 16, 2024
Merged
[IAM-1155] - provide thrown error details in return from computePermissions #44
nicolapalavecino
merged 1 commit into
muralco:master
from
reidblomquist:add/iam-1155-failure-reasons
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsrebot
reviewed
Jan 10, 2024
reidblomquist
force-pushed
the
add/iam-1155-failure-reasons
branch
from
January 10, 2024 23:17
66ed7cf
to
143f73f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, sorry if this is still a WIP
rsrebot
reviewed
Jan 11, 2024
rsrebot
reviewed
Jan 11, 2024
reidblomquist
force-pushed
the
add/iam-1155-failure-reasons
branch
from
January 11, 2024 16:10
143f73f
to
c0e8a43
Compare
reidblomquist
changed the title
[IAM-1155] - add ability to provide tryPermission function to computePermissions
[IAM-1155] - provide thrown error details in return from computePermissions so that clients ingesting might be better able to respond
Jan 11, 2024
reidblomquist
changed the title
[IAM-1155] - provide thrown error details in return from computePermissions so that clients ingesting might be better able to respond
[IAM-1155] - provide thrown error details in return from computePermissions
Jan 11, 2024
nicolapalavecino
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
rsrebot
approved these changes
Jan 12, 2024
…ssions so that clients ingesting might be better able to respond
reidblomquist
force-pushed
the
add/iam-1155-failure-reasons
branch
from
January 16, 2024 15:39
c0e8a43
to
ca52b1b
Compare
nicolapalavecino
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backwards compatible change to support IAM platform work; specifically being able to provide denial reasons and/or remediation options when computing permissions.
Encapsulating this new information in a new
$errors
property on returned permissions keeps backwards-compatibility intact.See this epic for more info: https://mural.atlassian.net/browse/IAM-1149