feat: initial polyfill functionality #173
Conversation
not required as we use node 18 as baseline
| get iceConnectionState() { | ||
| return this.#iceConnectionState; | ||
| return this.#peerConnection.state(); |
There was a problem hiding this comment.
This returns the same underlying prop for .connectionState and .iceConnectionState - I wasn't sure which one to use on the underlying PeerConnection but we don't use this in @libp2p/webrtc so it wasn't a big deal.
It would need fixing here though.
There was a problem hiding this comment.
yup, the type checks error on this, so it's visible to us that it needs to be changed
There was a problem hiding this comment.
I can add iceConnectionState to libdatachannel, is there something else missing?
There was a problem hiding this comment.
ice restart, Receivers, Senders, Transceivers, and maybe stats?
There was a problem hiding this comment.
About Receivers, Senders, and Transceivers, do you plan to polyfill tracks? I don't think this is possible currently, given tracks are lower level in libdatachannel and basically transceivers themselves (libdatachannel doesn't handle media encoding/decoding). For data channels however it can be done 1:1
There was a problem hiding this comment.
I don't know? I haven't even had time to test this as libdatachannel segfaults on my os and I haven't had time to debug it, we'd need to implement stuff from https://devdocs.io/dom/rtcstats/type
and I don't know what we'd need to track ourselves and what exists in libdatachannel
There was a problem hiding this comment.
polyfilling tracks means polyfilling mediasource, so pretty much faking it like mediasource.fromFilePath or some other non standard stuff, and a transceiver needs to exist to add a track, so then that might need to be faked too, idk dont have the time to check
this pr is just for the bare minimum simple functionality, so for now it's not something we need to worry about, but generating certificates and getting ICE data would be nice
There was a problem hiding this comment.
FYI I added the ICE connection state to libdatachannel in paullouisageneau/libdatachannel#944
There was a problem hiding this comment.
Thanks @paullouisageneau
I have integrated this feature now.
Is it possible to add restartIce function also or not possible?
|
NDC also needs to expose remote description which exist in libdatachannel |
ThaUnknown
changed the title
I have added this |
|
I am merging as it is. I could make changes though. |
|
@murat-dogan please tell me you at least tested this, because I didn't also paul is gonna add ice connection state, maybe ice reset and we already have remote description in libdatachannel, all of those need to be exposed in node-datachannel |
|
@ThaUnknown thank you for your help. I already added remotedesc method. |
No description provided.