Convert Code base to Typescript #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThaUnknown
reviewed
Jul 31, 2024
src/polyfill/RTCDataChannel.ts
Outdated
| import * as exceptions from './Exception'; | ||
| import { DataChannel } from '../lib/index'; | ||
|
|
||
| export default class RTCDataChannel extends EventTarget { |
There was a problem hiding this comment.
I'd do:
npm i @types/webrtc -D
and
/// <reference types="@types/webrtc" />
export default class RTCDataChannel extends EventTarget implements globalThis.RTCDataChannel {and use this implements keyword in all other W3C spec compliant classes, probably the best way to go around making sure the types are correct
There was a problem hiding this comment.
I will check that when I have time for this PR.
ThaUnknown
reviewed
Jul 31, 2024
| "strictNullChecks": false, | ||
| "noUnusedLocals": true, | ||
| "alwaysStrict": true, | ||
| "outDir": "./dist", |
There was a problem hiding this comment.
Suggested change
| "outDir": "./dist", | |
| "outDir": "./dist", | |
| "types": ["@types/webrtc"], |
ThaUnknown
reviewed
Jul 31, 2024
| "rollup-plugin-esbuild": "^6.1.1", | ||
| "ts-api-utils": "^1.3.0", | ||
| "ts-jest": "^29.2.3", | ||
| "ts-node": "^10.9.2", |
There was a problem hiding this comment.
tsx was the right choice, ts-node has massive memory overhead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.