Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto-loader: fix typescript generation callType for client streaming #3

Conversation

badsyntax
Copy link

@badsyntax badsyntax commented Oct 11, 2020

I noticed an unexpected type error with the following code:

const stream = client.clientStreamingCall(
  (error?: grpc.ServiceError) => {
    if (error) {
      console.error(error.message);
    } 
  }
);
// error: expected serverMesage
stream.write({
  clientMessage: 'Message from client',
});

Seems to me stream.write should be writing a request message not a response message.

@murgatroid99 murgatroid99 merged commit 08f7e4e into murgatroid99:proto-loader_type_generator Oct 11, 2020
murgatroid99 pushed a commit that referenced this pull request Jan 19, 2021
Prototype pollution fix - checking magic attributes - grpc-js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants