-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.15.0 #226
Draft
museun
wants to merge
30
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this gets rid of the connectors this implements the connectors as separate crates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
Connector
trait and favors independent crates. This'll allow more flexible versioning (and changes/additions) for external deps.This changes the
Encodable
trait to use a&mut dyn Write
so the trait implementations can be object safe.This removes the
AsyncRunner
and provides a bunch of composable functions instead.The
MpscWriter
is now usable in both sync and async contexts.Add
Sink
/Stream
wrappers forEncoder
/Decoder
Add a
Handshake
type that allows a connection flow to be started/wait for it to be ready.Remove most of the stuff from the root, re-export common types into distinct submodules:
sync
asynchronous
stream
Add an
idle_detection_loop
that does the 'complex' part of the old runner -- but is reusable and is opt-inWhat needs to be done: