Null ref #11
Merged
Null ref #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two refs
This is clear, two refs are two separate objects.
I suppose one could argue for this being true and implementing it in |
telephon
reviewed
Jan 16, 2023
classes/JSONlib.sc
Outdated
| @@ -31,7 +28,7 @@ JSONlib { | |||
| var array; | |||
| ^case | |||
| { v.isKindOf(Symbol) } { this.prConvertToJson(v.asString) } | |||
| { v == "null" or: { v.class == JSONlibNull } or: { v == nil } } { "null" } | |||
| { v == "null" or: { v.value == nil } or: { v == nil } } { "null" } | |||
There was a problem hiding this comment.
we should check for Ref class. Otherwise, you may lose a function like { |x| x !? (x+1) }
There was a problem hiding this comment.
... and it is confusing that we use the null string. Let's do two things only:
{ v.isNil or: { v.class == Ref and: { v.value.isNil } } }
There was a problem hiding this comment.
good point - can you check if it is better now?
telephon
reviewed
Jan 17, 2023
classes/JSONlib.sc
Outdated
| @@ -28,7 +28,8 @@ JSONlib { | |||
| var array; | |||
| ^case | |||
| { v.isKindOf(Symbol) } { this.prConvertToJson(v.asString) } | |||
| { v == "null" or: { v.value == nil } or: { v == nil } } { "null" } | |||
| // only check value if it is a ref | |||
| { (v.isKindOf(Ref)).if({v.value==nil}, {false}) or: { v == nil } } { "null" } | |||
There was a problem hiding this comment.
please instead of
{ (v.isKindOf(Ref)).if({v.value==nil}, {false}) or: { v == nil } } { "null" }make it
{ v.isNil or: { v.isKindOf(Ref) and: { v.value.isNil } } } { "null" }
telephon
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7 and closes #5
BTW, why is