add quickstart section #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telephon
reviewed
Jan 23, 2023
telephon
approved these changes
Jan 23, 2023
|
@telephon is adding an implicit conversion of Symbol to String ok? |
telephon
reviewed
Jan 23, 2023
README.md
Outdated
| @@ -31,18 +31,19 @@ HelpBrowser.openHelpFor("Classes/JSONlib"); | |||
|
|
|||
| #### Parse a JSON | |||
|
|
|||
| Lets parse the JSON which has an integer as a value | |||
| Lets say we have a JSON with an integer as a value | |||
telephon
reviewed
Jan 23, 2023
Tests/TestJSONlib.sc
Outdated
| this.assertEquals( | ||
| e[\hello], | ||
| 42, | ||
| "JSONlib should also accept Symbols beneath Strings", |
There was a problem hiding this comment.
what is a "symbol beneath a string"?
telephon
reviewed
Jan 23, 2023
classes/JSONlib.sc
Outdated
| @@ -17,6 +17,10 @@ JSONlib { | |||
| } | |||
|
|
|||
| *convertToSC {|string, customDecoder=nil, useEvent=true, postWarnings=true| | |||
There was a problem hiding this comment.
maybe rename "string" to "json" because it also may be a symbol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.