Skip to content

Commit

Permalink
Remove DETACHED_PROCESS
Browse files Browse the repository at this point in the history
What DETACHED_PROCESS does is to detach the child process from the current console disallowing the passing
of TTY handles. This seems incorrect and is inconsistent with Unix. If an application actually needs to
be detached, it can use FreeConsole itself.
  • Loading branch information
Keno authored and vtjnash committed Nov 14, 2018
1 parent 27e2b1b commit 404ad8f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/win/process.c
Original file line number Diff line number Diff line change
Expand Up @@ -1103,7 +1103,7 @@ int uv_spawn(uv_loop_t* loop,
* CreateProcess call fail if we're under job control that doesn't allow
* breakaway.
*/
process_flags |= DETACHED_PROCESS | CREATE_NEW_PROCESS_GROUP;
process_flags |= CREATE_NEW_PROCESS_GROUP;
}

if (options->cpumask != NULL) {
Expand Down

0 comments on commit 404ad8f

Please sign in to comment.