all: backport Go 1.19 os/exec behavior changes via execabs

This is probably overly conservative since this behavior doesn't affect
Mutagen to the extent that it affects the Go toolchain commands, but
it's an easy fix to make and shouldn't have any adverse effect on
Mutagen users.

For more background information, see https://go.dev/blog/path-security
and https://go.dev/doc/go1.19.

Signed-off-by: Jacob Howard <jacob@mutagen.io>

cmd/mutagen/daemon/start.go

@@ -6,6 +6,8 @@ import (
 	"os/exec"
 	"runtime"
 
+	"golang.org/x/sys/execabs"
+
 	"github.com/spf13/cobra"
 
 	"github.com/mutagen-io/mutagen/cmd"
@@ -31,7 +33,7 @@ func startMain(_ *cobra.Command, _ []string) error {
 	if !external.UsePathBasedLookupForDaemonStart {
 		executablePath, err = os.Executable()
 	} else {
-		executablePath, err = exec.LookPath(process.ExecutableName("mutagen", runtime.GOOS))
+		executablePath, err = execabs.LookPath(process.ExecutableName("mutagen", runtime.GOOS))
 	}
 	if err != nil {
 		return fmt.Errorf("unable to determine executable path: %w", err)

cmd/terminal_windows.go

@@ -6,6 +6,8 @@ import (
 	"os"
 	"os/exec"
 
+	"golang.org/x/sys/execabs"
+
 	isatty "github.com/mattn/go-isatty"
 )
 
@@ -22,7 +24,7 @@ func HandleTerminalCompatibility() {
 
 	// Since we're running inside a mintty-based terminal, we need to relaunch
 	// using winpty, so first attempt to locate it.
-	winpty, err := exec.LookPath("winpty")
+	winpty, err := execabs.LookPath("winpty")
 	if err != nil {
 		Fatal(errors.New("running inside mintty terminal and unable to locate winpty"))
 	}

pkg/docker/docker_darwin.go

@@ -1,7 +1,7 @@
 package docker
 
 import (
-	"os/exec"
+	"golang.org/x/sys/execabs"
 
 	"github.com/mutagen-io/mutagen/pkg/process"
 )
@@ -17,7 +17,7 @@ var commandSearchPaths = []string{
 func commandPathForPlatform() (string, error) {
 	// First, attempt to find the docker executable using the PATH environment
 	// variable. If that works, use that result.
-	if path, err := exec.LookPath("docker"); err == nil {
+	if path, err := execabs.LookPath("docker"); err == nil {
 		return path, nil
 	}
 

pkg/docker/docker_posix.go

@@ -3,10 +3,10 @@
 package docker
 
 import (
-	"os/exec"
+	"golang.org/x/sys/execabs"
 )
 
 // commandPathForPlatform searches for the docker command in the user's path.
 func commandPathForPlatform() (string, error) {
-	return exec.LookPath("docker")
+	return execabs.LookPath("docker")
 }

pkg/docker/docker_windows.go

@@ -1,10 +1,10 @@
 package docker
 
 import (
-	"os/exec"
+	"golang.org/x/sys/execabs"
 )
 
 // commandPathForPlatform searches for the docker command in the user's path.
 func commandPathForPlatform() (string, error) {
-	return exec.LookPath("docker")
+	return execabs.LookPath("docker")
 }

pkg/ssh/ssh_posix.go

@@ -3,15 +3,15 @@
 package ssh
 
 import (
-	"os/exec"
+	"golang.org/x/sys/execabs"
 )
 
 // sshCommandPathForPlatform searches for the ssh command in the user's path.
 func sshCommandPathForPlatform() (string, error) {
-	return exec.LookPath("ssh")
+	return execabs.LookPath("ssh")
 }
 
 // scpCommandPathForPlatform searches for the scp command in the user's path.
 func scpCommandPathForPlatform() (string, error) {
-	return exec.LookPath("scp")
+	return execabs.LookPath("scp")
 }