-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mux-video-react): Don't spread disableCookies to video to avoid warnings #749
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @luwes, can u have look and possibly merge this? Thanks |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
=======================================
Coverage 82.44% 82.44%
=======================================
Files 40 40
Lines 8381 8381
Branches 461 461
=======================================
Hits 6910 6910
Misses 1465 1465
Partials 6 6 |
@luwes is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the contribution!
Same issue as #602.
![Screenshot 2023-08-17 at 17 14 09](https://private-user-images.githubusercontent.com/40537200/261354518-04df66ba-a991-4ce2-ab63-ed9e80dc18f9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4ODIxNzMsIm5iZiI6MTczODg4MTg3MywicGF0aCI6Ii80MDUzNzIwMC8yNjEzNTQ1MTgtMDRkZjY2YmEtYTk5MS00Y2UyLWFiNjMtZWQ5ZTgwZGMxOGY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDIyNDQzM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRmNTlmZDIzYjViNjY1NmIyNmYwNDg4ODZmOWI2MDlmMTdjNWEyODgwMmEzYzg1MmE1YjBkNDU3YWJkNzQ5OWImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.jGmIeMbuKdRgYSO89XU6EAJLixyAIjeIYr21rLdb8ys)