Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mux-video-react): Don't spread disableCookies to video to avoid warnings #749

Merged
merged 6 commits into from
Dec 4, 2023
Merged

fix(mux-video-react): Don't spread disableCookies to video to avoid warnings #749

merged 6 commits into from
Dec 4, 2023

Conversation

pdolezal0
Copy link
Contributor

Same issue as #602.
Screenshot 2023-08-17 at 17 14 09

@pdolezal0 pdolezal0 requested a review from a team as a code owner August 17, 2023 15:15
@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 4:33pm
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 4:33pm
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 4:33pm
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 4:33pm
elements-demo-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 4:33pm

@pdolezal0 pdolezal0 changed the title fix(mux-video-react): Don't spread disabledCookies to video to avoid warnings fix(mux-video-react): Don't spread disableCookies to video to avoid warnings Aug 17, 2023
@pdolezal0
Copy link
Contributor Author

Hey @luwes, can u have look and possibly merge this? Thanks

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #749 (ae2e3a2) into main (31f6557) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #749   +/-   ##
=======================================
  Coverage   82.44%   82.44%           
=======================================
  Files          40       40           
  Lines        8381     8381           
  Branches      461      461           
=======================================
  Hits         6910     6910           
  Misses       1465     1465           
  Partials        6        6           

Copy link

vercel bot commented Dec 4, 2023

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the contribution!

@luwes luwes merged commit 06169be into muxinc:main Dec 4, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants