-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(playback-core): Make sure we do not apply holdback to seekable when live streams have ended. #891
fix(playback-core): Make sure we do not apply holdback to seekable when live streams have ended. #891
Conversation
…en live streams have ended.
@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #891 +/- ##
==========================================
- Coverage 81.76% 81.72% -0.05%
==========================================
Files 40 40
Lines 8517 8524 +7
Branches 468 468
==========================================
+ Hits 6964 6966 +2
- Misses 1547 1552 +5
Partials 6 6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the one!
In other words, seekable should only apply holdback (baked into
hls.liveSyncPosition
) while the live stream is "active"/"still live".