Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playback-core): Make sure we do not apply holdback to seekable when live streams have ended. #891

Merged

Conversation

cjpillsbury
Copy link
Contributor

In other words, seekable should only apply holdback (baked into hls.liveSyncPosition) while the live stream is "active"/"still live".

@cjpillsbury cjpillsbury requested a review from a team as a code owner March 27, 2024 15:50
Copy link

vercel bot commented Mar 27, 2024

@cjpillsbury is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 4:47pm
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 4:47pm
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 4:47pm
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 4:47pm
elements-demo-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 28, 2024 4:47pm

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 81.72%. Comparing base (acb8783) to head (ef8f8d8).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
- Coverage   81.76%   81.72%   -0.05%     
==========================================
  Files          40       40              
  Lines        8517     8524       +7     
  Branches      468      468              
==========================================
+ Hits         6964     6966       +2     
- Misses       1547     1552       +5     
  Partials        6        6              
Files Coverage Δ
packages/playback-core/src/index.ts 72.25% <37.50%> (-0.12%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Contributor

@AdamJaggard AdamJaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the one!

@cjpillsbury cjpillsbury merged commit 138e83f into muxinc:main Mar 28, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants