Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional types declaration to package.json #304

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Add additional types declaration to package.json #304

merged 1 commit into from
Jul 27, 2023

Conversation

decepulis
Copy link
Contributor

@decepulis decepulis commented Jul 27, 2023 •
edited
Loading

TS5 and --moduleResolution bundler require us to be a little more explicit with our types.

First realized this after create-next-app changed its default moduleResolution to bundler

CleanShot 2023-07-27 at 11 56 23@2x

The changes in this PR have been tested using yarn link against that create-next-app repo. VSCode integrations and ts build errors are back!
CleanShot 2023-07-27 at 11 58 35@2x
CleanShot 2023-07-27 at 11 59 38@2x

@decepulis decepulis requested a review from a team as a code owner July 27, 2023 16:57
cjpillsbury
cjpillsbury approved these changes Jul 27, 2023
View reviewed changes
Copy link

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@decepulis decepulis merged commit 6f915b6 into master Jul 27, 2023
@decepulis decepulis deleted the dc/add-additional-package-types branch July 27, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjpillsbury cjpillsbury cjpillsbury approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@decepulis @cjpillsbury