Avoid generating useless symlink #302
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| } | ||
| } catch (error) { | ||
| // Videos directory doesn't exist or is not accessible, which we treat the same as having no files | ||
| } |
There was a problem hiding this comment.
hey Liam, thanks for contributing!
this works when there initially are no video files but if I keep the Next.js app running and then add a video file to the folder there wouldn't be a symlink when refreshing the page.
the symlink is needed temporarily before the asset is uploaded / processed to show the raw local video file in the player in the webpage. only in dev mode.
There was a problem hiding this comment.
hey Wesley, that makes sense! Yeah, sorry I missed that. But, it looks like this might not be a valid issue, so I'll just close this.
I've been looking for projects to contribute to, so if you have any suggestions, let me know!
|
thinking through this today maybe it's not really a valid issue. I'll ask the reporter. |
Fixes #297
This codebase is new to me, so please let me know if I missed anything glaringly obvious.
I tested manually as well and everything checked out 🫡