Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.5.0 failed to push to Docker Hub #860

Closed
mvdan opened this issue May 11, 2022 · 6 comments
Closed

v3.5.0 failed to push to Docker Hub #860

mvdan opened this issue May 11, 2022 · 6 comments

Comments

@mvdan
Copy link
Owner

mvdan commented May 11, 2022

https://github.com/mvdan/sh/runs/6388354551?check_suite_focus=true

The version check thankfully caught that I messed up with the version stuff, but unfortunately it only runs on tags, and I strongly prefer not to re-tag v3.5.0.

I could manually build and push the images, but the buildx setup is slightly intricate and only configured as part of CI, so I won't do that either.

Instead, I'll tag v3.5.1 in a week with the docker build fix, so Docker Hub will just lag behind for a little while. Hopefully there will be at least one or two other fixes to include as part of the release.

mvdan added a commit that referenced this issue May 11, 2022
For #860, which is left open as a warning to users.
@mvdan mvdan pinned this issue May 11, 2022
@mvdan
Copy link
Owner Author

mvdan commented May 12, 2022

If anyone can't wait, you can use a recent digest from the latest tag, which is equivalent - there haven't been any code changes since v3.5.0 in the master branch yet. For example: https://hub.docker.com/layers/shfmt/mvdan/shfmt/latest/images/sha256-a89cee7bbb1ded7543169af3aeff1eba97884177f2c9af766105ecf56792bd61?context=explore

scop added a commit to scop/pre-commit-shfmt that referenced this issue May 19, 2022
Using "latest" for the docker image tag for now per
mvdan/sh#860 (comment)
mvdan added a commit that referenced this issue May 23, 2022
For #860, which is left open as a warning to users.
@mvdan mvdan closed this as completed May 23, 2022
@mvdan mvdan unpinned this issue May 23, 2022
@peikk0
Copy link

peikk0 commented Jun 3, 2022

@mvdan hello, can you please also publish a release with prebuilt binaries for v3.5.1?

@mvdan
Copy link
Owner Author

mvdan commented Jun 7, 2022

Huh, I thought I had done that as part of releasing v3.5.1 - I must have forgotten. Doing it now :)

@mvdan
Copy link
Owner Author

mvdan commented Jun 7, 2022

Done, thank you for the ping: https://github.com/mvdan/sh/releases/tag/v3.5.1

@peikk0
Copy link

peikk0 commented Jun 7, 2022

@mvdan thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants