Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trailing colon not trimmed when using relaxed mode and no scheme #74

Closed
cspeidel opened this issue Nov 8, 2023 · 1 comment
Closed

Trailing colon not trimmed when using relaxed mode and no scheme #74

cspeidel opened this issue Nov 8, 2023 · 1 comment

Comments

@cspeidel
Copy link
Contributor

cspeidel commented Nov 8, 2023 

xurls -version
v2.5.0

This leaves a trailing colon (not correct):

echo "example.com: leaves a colon" | xurls -r
example.com:

Doesn't leave a trailing colon (correct):

echo "http://example.com: no colon" | xurls -r
http://example.com

or

echo "http://example.com: no colon" | xurls
http://example.com

The first case is not consistent with the others.
@mvdan
Copy link
Owner

mvdan commented Nov 17, 2023

Thanks, this looks like a bug. Want to try sending a patch with a test?

cspeidel added a commit to cspeidel/xurls that referenced this issue Nov 17, 2023
@cspeidel
Ensure port has at least one number. Fixes mvdan#74.
9ed1ed2
@mvdan mvdan closed this as completed in e179eda Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mvdan @cspeidel