Skip to content

Commit

Permalink
minor updates to CONTRIBUTING.md (open-telemetry#419)
Browse files Browse the repository at this point in the history
  • Loading branch information
saurabhdes authored Oct 10, 2022
1 parent b27fa7d commit c146cb5
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ cd .\src\adservice\
all the images will be build):

```shell
docker compose up
docker compose up -d
```

### Verify the Webstore & the Telemetry
Expand All @@ -83,6 +83,8 @@ Once the images are built and containers are started you can access:
- Jaeger: <http://localhost:16686/>
- Prometheus: <http://localhost:9090/>
- Grafana: <http://localhost:3000/>
- Feature Flags UI: <http://localhost:8081/>
- Load Generator UI: <http://localhost:8089/>

## Create Your First Pull Request

Expand All @@ -100,7 +102,7 @@ git clone https://github.com/open-telemetry/opentelemetry-demo.git
Navigate to the repo root:

```sh
cd opentelemetry--demo
cd opentelemetry-demo
```

Add your fork as an origin:
Expand All @@ -113,8 +115,12 @@ Check out a new branch, make modifications and push the branch to your fork:

```sh
$ git checkout -b feature
# edit files
$ git commit
# change files
# Test your changes locally.
$ docker compose up -d --build
# Go to Webstore, Jaeger or docker container logs etc. as appropriate to make sure your changes are working correctly.
$ git add my/changed/files
$ git commit -m "short discription of the change"
$ git push fork feature
```

Expand Down

0 comments on commit c146cb5

Please sign in to comment.