Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement worldspace ui #299

Closed
wants to merge 5 commits into from

Conversation

Schmarni-Dev
Copy link
Contributor

this reimplements #214 while referencing a lot of parts of the pr

Signed-off-by: Schmarni <marnistromer@gmail.com>
Signed-off-by: Schmarni <marnistromer@gmail.com>
Schmarni-Dev and others added 2 commits August 2, 2024 16:31
Signed-off-by: Schmarni <marnistromer@gmail.com>
@mvlabat
Copy link
Owner

mvlabat commented Aug 9, 2024

Hi, thank you a lot for the PR, this is great! I'm still trying to find the time+energy to review and test it, so apologies for the delay.

I'm thinking how we should handle inputs for worldspace ui. I guess we need some sort of API to allow users pass mouse events casted to 3D surfaces.. Maybe users can manually emit native Bevy events by mapping keyboard/mouse events if they detect a cursor is over a 3D surface.

I think it's something we can try exploring in examples before providing a better API for it (it doesn't necessarily have to be introduced in this PR).

@Schmarni-Dev
Copy link
Contributor Author

i already have code to interact with world space egui using bevy_mod_picking here https://github.com/NexusSocial/nexus-vr/tree/main/crates/egui-picking, i just need to update it to use this impl and add improvements. i would like to upstream that to here once bevy upstreams bevy_mod_picking in 0.15

Signed-off-by: Schmarni <marnistromer@gmail.com>
@mvlabat
Copy link
Owner

mvlabat commented Aug 18, 2024

Merged as part of #304. Thank you for your help to drive this to completion!

@mvlabat mvlabat closed this Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants