Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paint callback support #303

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Paint callback support #303

merged 3 commits into from
Aug 18, 2024

Conversation

PPakalns
Copy link
Contributor

@PPakalns PPakalns commented Aug 17, 2024

Resolves #294

Bevy render graph nodes create render passes, paint callback can not be expanded into a render graph subgraph.

Graph node can contain custom rendering code or, for example, Render Phase abstraction to render multiple type of resources with multiple render pipelines in the current render pass.
This implementation supports bevy rendering logic with custom render implementation.

For now native wgpu RenderPass can not be used because of the following issue: bevyengine/bevy#13225

@mvlabat
Copy link
Owner

mvlabat commented Aug 18, 2024

Awesome work, thank you! I'm also amazed how it just works in browsers

@mvlabat
Copy link
Owner

mvlabat commented Aug 18, 2024

I pushed a couple of fixes to make CI happy and also did a small and a bit of unnecessary refactor, I hope it doesn't break anything :D

@mvlabat mvlabat merged commit 0815a1d into mvlabat:main Aug 18, 2024
39 checks passed
@mvlabat
Copy link
Owner

mvlabat commented Aug 18, 2024

I've just found a copy-paste error that I added: will be fixed in #304 if I manage to implement callbacks support for worldspace UI based on the current implementation (or separately).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support epaint::Shape::Callback(PaintCallback)
2 participants