-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gh action CI system #34
Conversation
use GH actions for CI system
I actually already have something very similar set up via Travis? See .travis.yml Edit - oh, I see, you're using this to test the build action |
I think the action is looking too many "zoobot"'s deep Obtaining file:///home/runner/work**/zoobot/zoobot/zoobot** |
More that travis CI has become a troubling place to host your CI system lately. They were bought out and the company that bought them are squeezing all they can out of folks. The CI run times are long and queue times more so. Also they've had security issues lately as well so most folks are moving OSS systems away from them. This should co-locate the code and CI system to GH and speed up the CI times significantly as well (faster feedback is good) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
- Failing on 3.10 is expected, pytorch/tensorflow devs usually lag a little behind the latest python due to (I assume) engineering effort requiredd
- Added build requirement for 3.7, which many academics use
Also, disabling Travis now via Travis UI |
use GH actions for CI system and this would replace travis CI system
Totally up to you if you want to adopt GH Actions for CI