Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gh action CI system #34

Merged
merged 9 commits into from
Oct 14, 2022
Merged

add gh action CI system #34

merged 9 commits into from
Oct 14, 2022

Conversation

camallen
Copy link
Collaborator

@camallen camallen commented Oct 14, 2022

use GH actions for CI system and this would replace travis CI system

Totally up to you if you want to adopt GH Actions for CI

use GH actions for CI system
@mwalmsley
Copy link
Owner

mwalmsley commented Oct 14, 2022

I actually already have something very similar set up via Travis? See .travis.yml

Edit - oh, I see, you're using this to test the build action

@mwalmsley
Copy link
Owner

I think the action is looking too many "zoobot"'s deep

Obtaining file:///home/runner/work**/zoobot/zoobot/zoobot**
ERROR: file:///home/runner/work/zoobot/zoobot/zoobot does not appear to be a Python project: neither 'setup.py' nor 'pyproject.toml' found.

@camallen
Copy link
Collaborator Author

I actually already have something very similar set up via Travis? See .travis.yml

Edit - oh, I see, you're using this to test the build action

More that travis CI has become a troubling place to host your CI system lately. They were bought out and the company that bought them are squeezing all they can out of folks. The CI run times are long and queue times more so. Also they've had security issues lately as well so most folks are moving OSS systems away from them.

This should co-locate the code and CI system to GH and speed up the CI times significantly as well (faster feedback is good)

@camallen camallen marked this pull request as ready for review October 14, 2022 09:22
@camallen camallen requested a review from mwalmsley October 14, 2022 09:26
Copy link
Owner

@mwalmsley mwalmsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

  • Failing on 3.10 is expected, pytorch/tensorflow devs usually lag a little behind the latest python due to (I assume) engineering effort requiredd
  • Added build requirement for 3.7, which many academics use

@mwalmsley
Copy link
Owner

Also, disabling Travis now via Travis UI

@mwalmsley mwalmsley merged commit 19cbdf8 into main Oct 14, 2022
@mwalmsley mwalmsley deleted the add-gh-actions-ci branch October 14, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants