Fix the demo shiny app with tabs

mwouts · Aug 10, 2024 · dd02403 · dd02403
1 parent e30f96a
commit dd02403
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -6,6 +6,7 @@ ITables ChangeLog
 
 **Fixed**
 - We have adjusted the generation of the Polars sample dataframes to fix the CI ([Polars-18130](https://github.com/pola-rs/polars/issues/18130))
+- The test on the Shiny app uses `ui.nav_panel` which replaces `ui.nav`
 
 
 2.1.4 (2024-07-03)

diff --git a/tests/sample_python_apps/itables_in_a_shiny_app.py b/tests/sample_python_apps/itables_in_a_shiny_app.py
@@ -1,3 +1,4 @@
+# Run this app with "shiny run file.py"
 from shiny import App, ui
 
 from itables.sample_dfs import get_countries
@@ -8,4 +9,3 @@
 app_ui = ui.page_fluid(ui.HTML(DT(df)))
 
 app = App(app_ui, server=None)
-# app.run()
diff --git a/tests/sample_python_apps/itables_in_a_shiny_app_with_tabs.py b/tests/sample_python_apps/itables_in_a_shiny_app_with_tabs.py
@@ -1,3 +1,4 @@
+# Run this app with "shiny run file.py"
 from shiny import App, ui
 
 from itables.sample_dfs import get_dict_of_test_dfs
@@ -6,9 +7,11 @@
 app_ui = ui.page_fluid(
     # Display the different tables in different tabs
     ui.navset_tab(
-        *[ui.nav(name, ui.HTML(DT(df))) for name, df in get_dict_of_test_dfs().items()]
+        *[
+            ui.nav_panel(name, ui.HTML(DT(df)))
+            for name, df in get_dict_of_test_dfs().items()
+        ]
     )
 )
 
 app = App(app_ui, server=None)
-# app.run()