-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
rough & minimal changes to get index.ts to compile
jlpm add @jupyterlab/application @jupyterlab/apputils @jupyterlab/codeeditor @jupyterlab/nbformat @jupyterlab/notebook @jupyterlab/rendermime @jupyterlab/translation @jupyterlab/ui-components
Thanks @mwouts for working on this! While investigating Jupytext support in Notebook 7 (jupyter/notebook#6914) it appears that the toolbar is missing when opening a markdown file with the default-viewers-jupytext-jupyterlab.mp4 |
Hey @jtpio , thank you for pointing this out! Well I am a bit clueless but I will pay attention to this, that is a strange pattern indeed. By the way I plan to work on this issue this week-end. I think I would have a preference to continue packaging everything (I mean the Python package, the CLI, the contents manager, the server and the jupyter lab extension) in |
Right that makes sense 👍 |
there currently are 2 different codebases for jlab3 and jlab4, and in this respect (as well as in other areas maybe) it could become a challenge for this reason I have asked discourse to see if the community has best practices on how to deal with that with these answers I can maybe propose to tweak the code of this extension to make it work with both jlab3 and jlab4, if that's helpful |
for the record, the issue mentioned above by @jtpio - missing toolbar in the juptext notebook widget - is also the topic of mwouts/jupytext#1107 and fixed in mwouts/jupytext#1109 |
Closing this PR as I am going to archive this repository (for the second time 😄) We will continue to provide the extension in Jupytext. Starting from |
Will close mwouts/jupytext#1054