Move the jupytext-config helpers to a subpackage, and add tests #1167
Conversation
|
@parmentelat does this look fine to you? Thanks! |
src/jupytext_config/labconfig.py
Outdated
| self.logger = logger or logging.getLogger(__name__) | ||
| self.config = {} | ||
| # the state before any changes | ||
| self._prior_config = {} | ||
| self.settings_file = Path(settings_path) / "default_setting_overrides.json" |
There was a problem hiding this comment.
imho if we're to be able to provide the location for the settings, i'td be better if the caller provides the whole path to the config file including its basename
my reason for that is, the configuration scheme within jupyterlab is truly complex, and with for example the overrides.d scheme, we may someday need to use another filename than this hard-coded default_setting_overrides.json
which amounts to dealing only with a single settings_path all over the place
mwouts
force-pushed
the
coverage_jupytext_config
branch
from
ed53fd9
to
1feace3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1167 +/- ##
==========================================
+ Coverage 97.59% 97.61% +0.02%
==========================================
Files 26 29 +3
Lines 4357 4451 +94
==========================================
+ Hits 4252 4345 +93
- Misses 105 106 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mwouts
force-pushed
the
coverage_jupytext_config
branch
from
839b83d
to
154b876
Compare
mwouts
force-pushed
the
coverage_jupytext_config
branch
from
154b876
to
15452de
Compare
Closes #1097