-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Jupytext for JupyterLab #877
Conversation
- Make `ICommandPalette` optional (support for RISE) - Support translation - Add new factory to open supported file directly with notebook view
The initial needs for this PR is to make I took that chance to add support for translation and improve a painful use case of opening directly md file with the notebook view. |
Hello @fcollonval , thank you so much for this! I'll find some time this week to review and test this, but already I am looking forward to it, indeed some of the issues you address here have been there for a while! |
I gave a quick try to a local build tonight, and took a few notes of what worked as expected, and what did not:
@fcollonval what do you get for double click / links? Or maybe my local install did not work? (I used |
This is strange. I just tried on Binder: https://mybinder.org/v2/gh/fcollonval/jupytext/main and md files open with the notebook viewer. |
Thanks for the link, I do agree - I'll retry from scratch tonight. So we're good with the double click (I am eager to test with this combined with the configuration option). Re the md links in notebooks, I had the impression that (on the binder repo above) they open with the markdown viewer rather than the notebook viewer, does this means that we need to change another setting to open them with the notebook viewer? |
This one is not working as expected; this should be fixed upstream (Xref jupyterlab/jupyterlab#7776). so that if the user defines another default viewer, it will be picked when open markdown link. |
Add widgets opened by the new factory to the notebook factory so commands will work
@mwouts I created the following screencast for the documentation to change the default viewer on JupyterLab. I'm a bit confused on where to put it. |
Thanks for the screenshot, that is very helpful ! Maybe we can add the screenshot, together with a text version of the config file (so that the user can simply copy/paste), in |
> It will be displayed only when merged + Set the default viewers on binder
I updated the doc and the binder configuration to change the default viewers.
|
Thank you @fcollonval , this is great! I plan to do another testing session tonight, and if all goes well I hope to ship a new version as well. Thank you so much for you work here! |
Well, developing the lab extension is obviously not so easy for me... I still cannot reproduce the new functionality locally 😢 Most probably I am not using the right approach to build the development version of the application? I have followed my notes but maybe they are outdated? Also I've tried
from the development documentation, but that one complained about Anyway I'll integrate your changes as I have seen it working on Binder... and if you have any advice on how to test locally then I am all ears! |
I've seen it working locally, finally! I just had to remove the two local versions of the extension...
|
Hey @mwouts The logic I followed to install this package (including lab extension) in dev mode is:
The latest command will symlink the dev lab extension within the lab extensions folder. |
Jupytext strings are ready to be translated: https://crowdin.com/project/jupyterlab/content/files |
@mwouts FYI I created a gist to demonstrate JupyterLab + Jupytext with French translation: https://gist.github.com/fcollonval/527631f0193f8c4f801d68e1b90a5ba2 |
ICommandPalette
optional (support for RISE)In JupyterLab, the default behavior is still to open the markdown file through the context menu. But that can be changed in the settings.