Skip to content

Commit

Permalink
Fix architecture specified for Windows wheels
Browse files Browse the repository at this point in the history
  • Loading branch information
mwydmuch committed Jan 7, 2024
1 parent 13c9e32 commit e9c3e59
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 1 deletion.
40 changes: 39 additions & 1 deletion .github/workflows/build-wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
# Configure cibuildwheel to build native archs, and some emulated ones
CIBW_ARCHS_LINUX: x86_64 aarch64
CIBW_ARCHS_MACOS: x86_64
CIBW_ARCHS_WINDOWS: x86_64
CIBW_ARCHS_WINDOWS: AMD64
CIBW_BUILD_VERBOSITY: 3
CIBW_REPAIR_WHEEL_COMMAND_LINUX: >
auditwheel show {wheel} && auditwheel repair -w {dest_dir} {wheel}
Expand Down Expand Up @@ -69,6 +69,44 @@ jobs:
with:
path: dist/*.tar.gz

# test_wheels:
# name: Test wheels
# needs: [build_wheels]
# runs-on: ${{ matrix.os }}
# strategy:
# matrix:
# os: [ubuntu-22.04, macos-11, windows-2019]
# python-version: [ '3.8', '3.9', '3.10', '3.11', '3.12' ]

# steps:
# - name: Download wheels
# uses: actions/download-artifact@v3
# with:
# # Unpacks default artifact into dist/
# # If `name: artifact` is omitted, the action will create extra parent dir
# name: artifact
# path: dist

# - name: Set up Python ${{ matrix.python-version }} environment
# uses: actions/setup-python@v4
# with:
# python-version: ${{ matrix.python-version }}

# - name: Python environment report
# run: python -c "import sys; print(sys.version)"

# - name: Upgrade pip and install pytest
# run: |
# python -m pip install --upgrade pip
# pip install pytest scikit-learn==1.2.2

# - name: Pip install
# run: pip install dist/*.whl

# - name: Run tests
# shell: bash
# run: pytest python/tests/test_*

upload_pypi:
name: Upload to PyPI
needs: [build_wheels, build_sdist]
Expand Down
3 changes: 3 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,7 @@ manylinux-aarch64-image = "manylinux2014"
before-all = "brew install cmake"

[tool.cibuildwheel.windows]

# Only build for AMD64 is officially supported
archs = "AMD64"
before-all = "choco install -y cmake"

0 comments on commit e9c3e59

Please sign in to comment.