Update to Xcode 14 / Swift 5.7 #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires dropping support for iOS/tvOS <11, macOS < 10.13, watchOS < 4.
ghost
marked this pull request as ready for review
ghost
marked this pull request as draft
ghost
marked this pull request as ready for review
|
Yeah I don't think changing the podspec is necessary. CocoaPods generates a compliant xcodeproj. By changing the pod spec you are potentially breaking anyone who uses this framework with old Xcodes to deliberately target old iOS versions. The xcodeproj changes are ok though as there is no choice with Carthage. |
|
I'm sorry, its been some time since I have last used CocoaPods. |
mxcl
approved these changes
Mar 31, 2023
|
Deploying 6.22.1. Which is really an incorrect semver bump since this changes platform requirements. But it's only for Carthage so… |
Merged
This was referenced May 31, 2023
Cocoapods's pods that depend on PromiseKit 6.22.1+ fail to
pod lib lint while using Xcode 14.3
#1317
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires dropping support for iOS/tvOS <11, macOS < 10.13, watchOS < 4.
Resolve #1308