Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Node 16 LTS #74

Merged
merged 5 commits into from
Dec 13, 2021
Merged

Migrate to Node 16 LTS #74

merged 5 commits into from
Dec 13, 2021

Conversation

chris-araman
Copy link
Collaborator

The GitHub Actions runner recently gained support for Node 16.

However, it looks like that hasn't yet been deployed to all runners, so I'm leaving this in Draft for the time being.

  • mxcl/xcodebuild checks fail
  • chris-araman/CombineCloudKit checks succeed

I suspect it'll be deployed along a similar timeline to their changing the default Node version (over the next few days).

@mxcl
Copy link
Owner

mxcl commented Dec 1, 2021

Oh wonderful, I need this for @git-things-done/template

@chris-araman
Copy link
Collaborator Author

chris-araman commented Dec 3, 2021

Interestingly, the checks seem to pass in the latest manual run. However, I don't know how to determine whether runner v2.285.0 is included in a given actions/virtual-environments image. I'm not finding the runner version in the macos-11 or macos-10.15 READMEs.

Per conversation here, it sounds like we should wait for an announcement of general availability here before merging this PR.

@chris-araman
Copy link
Collaborator Author

@chris-araman chris-araman marked this pull request as ready for review December 13, 2021 22:19
Copy link
Owner

@mxcl mxcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful.

@chris-araman chris-araman merged commit 7375a11 into master Dec 13, 2021
@chris-araman chris-araman deleted the node16 branch December 13, 2021 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants