-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support App Store Connect API keys and provisioning profiles #75
Conversation
This comment has been minimized.
This comment has been minimized.
Looks like I may need to make use of actions/cache. |
We should bump to Unless we can reasonably prove this only effects <2 projects. (Not sure we can prove anything). |
I'm not planning to remove any inputs. I reorganized the
None of these should be mutually exclusive, in theory. The simplest usage for most users should be the API key alone. To Do:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Safely additive.
Sorry for the delay. It's been, uh, an unexpectedly busy few weeks. 😅 Still investigating the To Dos above. |
nps dude; to me you’re an open source king 👑 |
I think I've convinced myself that the propagation of provisioning profiles is generally useful. Unfortunately, I think the App Store Connect API functionality is only useful for self-hosted runners, where private keys persist. Would you be comfortable accepting this PR in order to support the functionality only for self-hosted runners? Support for GitHub-hosted runners could be added in a later PR by persisting any private keys installed using the App Store Connect API. I want to err on the side of incremental progress, and I worry about letting this PR die on the vine. |
Possibly the private key could be written to the repo as a secret? Either way that can happen later. It’s fine that this only works for private runners provided we document it as such. |
Sounds good. I'll add some clarifying documentation to the README and YAML, then merge. Probably tonight or tomorrow. I can (minor) release, too, if you like. |
Ooh, that's a neat tack. I think it'd still be one private key per Device UUID, but that could be included in the secret name. |
Yep please bump too! |
Closes #71.
Using an App Store Connect API key with Xcode >= 13 allows automatic device registration, certificate creation, and provisioning profile creation.
Users who want to use an existing provisioning profile, or who use Xcode < 13, can now pass a list of Base64-encoded Mac or iOS provisioning profiles.