fix: hw2-1319 - Rename product search parameter

mxenabled · Jul 22, 2024 · c64533f · c64533f
1 parent 8d50947
commit c64533f
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 12 deletions.
diff --git a/mdx-models/src/main/java/com/mx/path/model/mdx/model/products/Product.java b/mdx-models/src/main/java/com/mx/path/model/mdx/model/products/Product.java
@@ -33,8 +33,7 @@ public final class Product extends MdxBase<Product> {
 
   private String name;
 
-  @SerializedName("product_type")
-  private String productType;
+  private String type;
 
   public List<Challenge> getActivateChallenges() {
     return activateChallenges;
@@ -116,12 +115,12 @@ public void setName(String name) {
     this.name = name;
   }
 
-  public String getProductType() {
-    return productType;
+  public String getType() {
+    return type;
   }
 
-  public void setProductType(String productType) {
-    this.productType = productType;
+  public void setType(String type) {
+    this.type = type;
   }
 
 }
diff --git a/mdx-models/src/main/java/com/mx/path/model/mdx/model/products/ProductSearch.java b/mdx-models/src/main/java/com/mx/path/model/mdx/model/products/ProductSearch.java
@@ -7,14 +7,14 @@
 @SuppressWarnings({ "checkstyle:MemberName", "checkstyle:ParameterName", "checkstyle:MethodName" })
 public class ProductSearch {
 
-  private String product_type;
+  private String type;
 
-  public final String getProduct_type() {
-    return product_type;
+  public final String getType() {
+    return type;
   }
 
-  public final void setProduct_type(String product_type) {
-    this.product_type = product_type;
+  public final void setType(String type) {
+    this.type = type;
   }
 
 }
diff --git a/mdx-web/src/test/groovy/com/mx/path/model/mdx/web/controller/ProductControllerTest.groovy b/mdx-web/src/test/groovy/com/mx/path/model/mdx/web/controller/ProductControllerTest.groovy
@@ -40,7 +40,7 @@ class ProductControllerTest extends Specification {
   def "listProducts interacts with gateway"() {
     given:
     def search = new ProductSearch().tap {
-      product_type = "ACCOUNT"
+      type = "ACCOUNT"
     }
     def mockResponse = new AccessorResponse<MdxList<Product>>().withResult(new MdxList<>().tap {
       add(new Product())