fix!: remove custom variables for hw that are not needed #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustin-hurst
requested review from
mattnichols,
gerfboy,
RyanJones08,
tessstoddard and
stevecl5
as code owners
|
This wont break hw connector as well as we never end up using them I believe, I could be wrong. can you please make sure these fields are removed from the spec already ? |
dustin-hurst
force-pushed
the
dustin/hw2-493
branch
from
7d0bee7
to
181963e
Compare
tessstoddard
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Match spec changes:
https://gitlab.mx.com/mx/gutenberg/-/merge_requests/871
9 custom variables were added to Account for HW that are no longer needed, so they are being removed. Along with a custom variable for StopPayment.
Fixes # (issue)
https://mxcom.atlassian.net/browse/HW2-493
Public API Additions/Changes
Anything related to Account.
Downstream Consumer Impact
This will only break the HW connector, which I will handle myself.
How Has This Been Tested?
Checklist: