Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self update for youtube-dl #119

Closed
Rpsl opened this issue Apr 14, 2020 · 6 comments
Closed

Self update for youtube-dl #119

Rpsl opened this issue Apr 14, 2020 · 6 comments
Labels
A-ytdl Area: youtube-dl C-feature-request Category: A feature request P-high High priority

Comments

@Rpsl
Copy link
Contributor

Rpsl commented Apr 14, 2020

I think can add additional cron job @daily for execution self update of youtube-dl

$ youtube-dl -U 
youtube-dl is up-to-date (2020.03.24)
@726a67
Copy link

726a67 commented Apr 17, 2020

Agreed, this can particularly frustrate usage via docker, as users pulling the latest image from dockerhub are limited to the version of youtube-dl explicitly installed by the current podsync Dockerfile (2020.01.24).

A cron job used to regularly self-update youtube-dl could solve this problem, but it might also be worth considering the use of pip to install the latest version of youtube-dl at image build time -- the latter would probably better align with standard docker deployment methodologies, e.g.:

FROM alpine:3.10

WORKDIR /app/
RUN \
    apk --no-cache add ca-certificates python py-pip ffmpeg && \
    pip install --upgrade pip && \
    pip install youtube-dl
COPY podsync /app/podsync
CMD ["/app/podsync"]

@mxpv mxpv added A-ytdl Area: youtube-dl C-feature-request Category: A feature request P-high High priority labels Apr 18, 2020
Rpsl added a commit to Rpsl/podsync that referenced this issue Apr 19, 2020
Rpsl added a commit to Rpsl/podsync that referenced this issue Apr 19, 2020
mxpv added a commit that referenced this issue Apr 19, 2020
mxpv pushed a commit that referenced this issue Apr 19, 2020
@mxpv
Copy link
Owner

mxpv commented Apr 19, 2020

Can you guys give it a try? (you can download latest non-release binaries from here: https://github.com/mxpv/podsync/actions/runs/82314116)

@726a67
Copy link

726a67 commented Apr 21, 2020

@mxpv Could you upload/tag a 'preview' or 'test' image to dockerhub containing the binary you'd like me to test? I only deploy podsync via docker, so testing the binary directly is problematic.

@mxpv
Copy link
Owner

mxpv commented Apr 23, 2020

Will add: #135

@DeXteRrBDN
Copy link
Contributor

DeXteRrBDN commented May 5, 2020

Not exactly self update, but at least update for those like me that use only the Docker version:

Managed to work with current Docker version and latest youtube-dl, just added the following volume mapping to docker-compose.yml:

- ./youtube-dl:/usr/bin/youtube-dl

version: '2.2'

services:
  podsync:
    container_name: podsync
    image: mxpv/podsync:latest
    restart: always
    ports:
      - 80:80
    volumes:
      - ./data:/app/data/
      - ./config.toml:/app/config.toml
      - ./youtube-dl:/usr/bin/youtube-dl

Then downloaded youtube-dl from latest version on GitHub and it started to work. I can update youtube-dl manually now using docker image!

@mxpv
Copy link
Owner

mxpv commented Sep 26, 2020

Self update is implemented in 2.3.0.
Use the following in your config file:

[downloader]
self_update = true # Optional, auto update youtube-dl every 24 hours

@mxpv mxpv closed this as completed Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ytdl Area: youtube-dl C-feature-request Category: A feature request P-high High priority
Projects
None yet
Development

No branches or pull requests

4 participants