Make the hard timeout on youtube-dl execution configurable #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ong should we wait on youtube-dl to download a video - default 30 minutes
# Conflicts: # pkg/ytdl/ytdl.go
mxpv
added a commit
that referenced
this pull request
Oct 17, 2020
|
Hello. Thanks for your PR. I think this can be implemented a bit easier (see d39e464). I pushed the changes to |
dop251
pushed a commit
to dop251/podsync
that referenced
this pull request
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the timeout for youtube-dl is hard coded. After 10 minutes youtube-dl is killed no question asked.
This pull request make this timeout an optional setting from config.toml and change the default to 30 minutes.
This is my first dab at Go, but at least it seems to work for me.