Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dockerfile: source youtube-dl from alpine repos #195

Merged
merged 1 commit into from
Nov 12, 2020
Merged

dockerfile: source youtube-dl from alpine repos #195

merged 1 commit into from
Nov 12, 2020

Conversation

jtagcat
Copy link
Contributor

@jtagcat jtagcat commented Nov 5, 2020

Does not close #191, but a temporary solution.

WARN: updating youtube-dl will fail.

It looks like you installed youtube-dl with a package manager, pip, setup.py or a tarball. Please use that to update.

Instead, to update, use the cmd:

apk --repository=http://dl-cdn.alpinelinux.org/alpine/edge/main add youtube-dl

I don't know how to do this in go, and if so, the binary needs a switch, if run from docker, indicating that it shall be upgraded via alpine's paman instead.

@jtagcat
Copy link
Contributor Author

jtagcat commented Nov 5, 2020

cc @mxpv for quick merge, build, and push of the image
thanks

Copy link
Owner

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as workaround until we figure out what to do with youtube-dl

Dockerfile Outdated Show resolved Hide resolved
@jtagcat jtagcat requested a review from mxpv November 8, 2020 13:29
@mxpv mxpv merged commit d7885eb into mxpv:master Nov 12, 2020
@jtagcat jtagcat deleted the ydl-alpine branch November 13, 2020 12:56
mxpv added a commit that referenced this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

youtube-dl taken down - future of podsync?
2 participants