Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNF URLs MUST be relative #34

Closed
job opened this issue May 20, 2024 · 3 comments · Fixed by #41
Closed

UNF URLs MUST be relative #34

job opened this issue May 20, 2024 · 3 comments · Fixed by #41

Comments

@job
Copy link
Collaborator

job commented May 20, 2024

This helps avoid weird XSS / cross-origin considerations

@job
Copy link
Collaborator Author

job commented May 20, 2024

As discussed at RIPE 88 @mxsasha

@job
Copy link
Collaborator Author

job commented May 22, 2024

@stkonst the reason the UNF's need to contain relative URLs is that you want to avoid cross-origin trickery, for example "my" UNF pointing to RIPE NCC's giant snapshot (but not at RIPE NCC's deltas); this would cause clients to endlessly download the latest snapshot, increasing bandwidth consumption beyond what is acceptable.

The same security concern was discovered in RRDP, and unfortunately the only viable workaround was to impose a 'same origin policy': https://datatracker.ietf.org/doc/html/draft-spaghetti-sidrops-rrdp-same-origin-00 and had to be patched in all validators.

But since NRTMv4 is still in its development phase, it is not too late to mandate only relative URLs are used, for safety

@job
Copy link
Collaborator Author

job commented May 22, 2024

Now, the RRDP situation and the NRTM v4 situation aren't 100% apples to apples, but I suspect that based on the RRDP experience (which was a big inspiration for NRTM v4), we'd do well to keep things simpler and only allow 'same-domain-file-serving'

@mxsasha mxsasha linked a pull request Oct 30, 2024 that will close this issue
@mxsasha mxsasha closed this as completed in 0731abe Nov 8, 2024
mxsasha added a commit that referenced this issue Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant