Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect desynchronization #33

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Conversation

job
Copy link
Collaborator

@job job commented May 16, 2024

@job
Copy link
Collaborator Author

job commented May 16, 2024

The wording might need a bit of wordsmithing, the goal is not to endlessly cache delta serials & hashes, but just check for the last 100 or 200 whether the server is rewriting history. In the RPKI RRDP this approach has proven useful

@mxsasha
Copy link
Owner

mxsasha commented May 16, 2024

Might edit words a bit, but it's a good scenario to detect, and I think this approach is light enough to expect the client to run every minute.

@mxsasha
Copy link
Owner

mxsasha commented May 27, 2024

Rephrased a bit to make clear what the exact comparison is. And changed client behaviour to just reject on mismatch: it indicates something very wrong with the server, and rejecting further updates and logging errors seems like a better approach.

@job
Copy link
Collaborator Author

job commented May 27, 2024

The advantage of switching to the Snapshot is that it automatically resets the state to something consistent. I think this auto repair is desirable over "halt and catch fire", because ultimately the administrator will want to reset the state anyway. So logging an issue and automatic remediation would be my preference, just like is done in RRDP

@mxsasha
Copy link
Owner

mxsasha commented May 27, 2024

But it resets the state to something consistent generated by a really broken nrtmv4 server implementation. If we know the server can't generate correct deltas, what makes us think it will generate a correct snapshot? Why trust anything it says until it is actually fixed?

mxsasha added a commit to irrdnet/irrd that referenced this pull request Nov 8, 2024
mxsasha added a commit to irrdnet/irrd that referenced this pull request Nov 8, 2024
mxsasha added a commit to irrdnet/irrd that referenced this pull request Nov 8, 2024
mxsasha added a commit to irrdnet/irrd that referenced this pull request Nov 8, 2024
@mxsasha mxsasha merged commit 7cc089c into mxsasha:main Nov 8, 2024
mxsasha added a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants