Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor♻️] Refactor Broker crate with BrokerRuntimeInner #2217

Closed
5 tasks done
mxsm opened this issue Jan 11, 2025 · 0 comments · Fixed by #2218
Closed
5 tasks done

[Refactor♻️] Refactor Broker crate with BrokerRuntimeInner #2217

mxsm opened this issue Jan 11, 2025 · 0 comments · Fixed by #2218
Labels
refactor♻️ refactor code rocketmq-broker crate rust Pull requests that update Rust code
Milestone
v0.4.0

Comments

@mxsm
Copy link
Owner

mxsm commented Jan 11, 2025

Which part of the code will be refactored?

No response

What problems does the refactor aim to solve?

No response

Do you have any specific design or implementation considerations?

No response

Is there a related issue or PR?

No response

Checklist

  • Ensure the refactor does not introduce new bugs

  • Update unit tests if applicable

  • Ensure the refactor does not negatively impact performance

  • Document any new patterns or architecture changes

  • Test the refactor in different environments (e.g., staging, production)
@mxsm mxsm added refactor♻️ refactor code rust Pull requests that update Rust code rocketmq-broker crate labels Jan 11, 2025
@RocketmqRustBot RocketmqRustBot added this to the v0.4.0 milestone Jan 11, 2025
@mxsm mxsm changed the title [Refactor♻️] Refactor Broker with BrokerInner [Refactor♻️] Refactor Broker crate with BrokerRuntimeInner Jan 12, 2025
mxsm added a commit that referenced this issue Jan 12, 2025
@mxsm
[ISSUE #2217]💫Refactor Broker crate with BrokerRuntimeInner♻️
ae7b806
@mxsm mxsm mentioned this issue Jan 12, 2025
Merged
rocketmq-rust-bot pushed a commit that referenced this issue Jan 12, 2025
@mxsm
[ISSUE #2217]💫Refactor Broker crate with BrokerRuntimeInner♻️ (#2218)
f8080ff
mxsm added a commit that referenced this issue Jan 12, 2025
@mxsm
[ISSUE #2217]💫Remove KVConfigManager #[derive(Clone)]🧑‍💻
63340b1
This was referenced Jan 12, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor♻️ refactor code rocketmq-broker crate rust Pull requests that update Rust code
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

[ISSUE #2217]💫Refactor Broker crate with BrokerRuntimeInner♻️ mxsm/rocketmq-rust
2 participants
@mxsm @RocketmqRustBot