[ISSUE #2170]🐛Fix BatchUnregistrationService not started when Name server start #2171
Conversation
WalkthroughThis pull request addresses a bug related to the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
rocketmq-rust-bot
requested review from
rocketmq-rust-bot,
SpaceXCN and
TeslaRustor
|
🔊@mxsm 🚀Thanks for your contribution🎉！ 💡CodeRabbit(AI) will review your code first🔥！ Note 🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥. |
rocketmq-rust-bot
added
AI review first
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
rocketmq-namesrv/src/route/batch_unregistration_service.rs (1)
57-57: Improve log message format.The current log message format with multiple
>and<characters is unconventional. Consider using a clearer format.- info!(">>>>>>>>BatchUnregistrationService started<<<<<<<<<<<<<<<<<<<"); + info!("BatchUnregistrationService started");
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
rocketmq-namesrv/src/route/batch_unregistration_service.rs(2 hunks)rocketmq-namesrv/src/route/route_info_manager.rs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (9)
- GitHub Check: build (windows-latest, nightly)
- GitHub Check: build (windows-latest, stable)
- GitHub Check: build (macos-latest, nightly)
- GitHub Check: build (macos-latest, stable)
- GitHub Check: build (ubuntu-latest, nightly)
- GitHub Check: build
- GitHub Check: test
- GitHub Check: build (ubuntu-latest, stable)
- GitHub Check: auto-approve
🔇 Additional comments (1)
rocketmq-namesrv/src/route/route_info_manager.rs (1)
1210-1210: LGTM! This fixes the BatchUnregistrationService startup issue.The change ensures that the BatchUnregistrationService is properly initialized when the RouteInfoManager starts. This is the correct fix for the reported issue.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2171 +/- ##
==========================================
- Coverage 28.76% 28.76% -0.01%
==========================================
Files 498 498
Lines 71036 71038 +2
==========================================
Hits 20435 20435
- Misses 50601 50603 +2 ☔ View full report in Codecov by Sentry. |
rocketmq-rust-bot
added
approved
Which Issue(s) This PR Fixes(Closes)
Fixes #2170
Brief Description
How Did You Test This Change?
Summary by CodeRabbit
New Features
Chores