[ISSUE #2281]🚀BrokerStatsManager and ColdDataCgCtrService add start method

[mxsm]

Which Issue(s) This PR Fixes(Closes)

Fixes #2281

Brief Description

How Did You Test This Change?

Summary by CodeRabbit

• New Features
  • Added start() method to ColdDataCgCtrService
  • Added start() method to BrokerStatsManager

Note: These methods are currently placeholder implementations with no functional changes to the existing system.

[coderabbitai]

Walkthrough

This pull request introduces start methods to two different services in the RocketMQ Rust implementation: ColdDataCgCtrService in the broker module and BrokerStatsManager in the store module. Both methods are currently minimal, with the ColdDataCgCtrService method including a warning log, and the BrokerStatsManager method being a no-op function. These additions appear to be part of a broader effort to standardize service initialization across the project.

Changes

File	Change Summary
rocketmq-broker/src/coldctr/cold_data_cg_ctr_service.rs	Added pub fn start(&mut self) method with a warning log
rocketmq-store/src/stats/broker_stats_manager.rs	Added pub fn start(&self) method with no implementation

Assessment against linked issues

Objective	Addressed	Explanation
Add start method to BrokerStatsManager [#2281]	✅
Add start method to ColdDataCgCtrService [#2281]	✅

Possibly related PRs

• [ISSUE #2261]🚀ColdDataCgCtrService and ColdDataPullRequestHoldService add shutdown method #2262: Adds shutdown method to ColdDataCgCtrService
• [ISSUE #2277]🚀AckMessageProcessor and BroadcastOffsetManager add start method #2278: Introduces start method to AckMessageProcessor

Suggested reviewers

• TeslaRustor
• SpaceXCN
• rocketmq-rust-bot

Poem

🚀 Startup sequence, rabbit's delight,
Methods emerging, taking flight
start() whispers soft and clear
Initializing without fear
RocketMQ's code, a bunny's dream 🐰

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[rocketmq-rust-bot]

🔊@mxsm 🚀Thanks for your contribution🎉！

💡CodeRabbit(AI) will review your code first🔥！

Note

🚨The code review suggestions from CodeRabbit are to be used as a reference only, and the PR submitter can decide whether to make changes based on their own judgment. Ultimately, the project management personnel will conduct the final code review💥.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

rocketmq-broker/src/coldctr/cold_data_cg_ctr_service.rs (1)

24-26: Track implementation status with GitHub issue.

The start method is currently a placeholder with a warning log. This matches the pattern used in the shutdown method, indicating planned but unimplemented functionality.

Would you like me to create a GitHub issue to track the implementation of both the start and shutdown methods for ColdDataCgCtrService?

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a3e692a and 0da4226.

📒 Files selected for processing (2)

• rocketmq-broker/src/coldctr/cold_data_cg_ctr_service.rs (1 hunks)
• rocketmq-store/src/stats/broker_stats_manager.rs (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: build (windows-latest, nightly)
• GitHub Check: build (windows-latest, stable)
• GitHub Check: build (macos-latest, nightly)
• GitHub Check: build (macos-latest, stable)
• GitHub Check: build (ubuntu-latest, nightly)
• GitHub Check: build
• GitHub Check: build (ubuntu-latest, stable)
• GitHub Check: test
• GitHub Check: auto-approve

🔇 Additional comments (1)

rocketmq-store/src/stats/broker_stats_manager.rs (1)

101-104: Verify if no-op implementation is intentional.

While ColdDataCgCtrService logs a warning about incomplete implementation, this service's start method is marked as "nothing to do". Please verify if this is intentional or if initialization logic is needed.

Consider adding a comment explaining why no initialization is needed, or if this is a placeholder, use a warning log like in ColdDataCgCtrService for consistency.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 28.24%. Comparing base (a3e692a) to head (0da4226).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...tmq-broker/src/coldctr/cold_data_cg_ctr_service.rs	0.00%	3 Missing ⚠️
rocketmq-store/src/stats/broker_stats_manager.rs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2282      +/-   ##
==========================================
- Coverage   28.24%   28.24%   -0.01%     
==========================================
  Files         504      504              
  Lines       72363    72369       +6     
==========================================
  Hits        20438    20438              
- Misses      51925    51931       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rocketmq-rust-bot]

LGTM